com.utilities.websockets 1.1.0 #18
Conversation
- fix webgl build regressions when using multi-threaded environments
There was a problem hiding this comment.
Pull Request Overview
This PR updates the com.utilities.websockets package to version 1.0.7, addressing WebGL function name collisions and updating test infrastructure. The changes ensure the WebSocket plugin works correctly in multi-threaded WebGL environments by renaming internal functions to avoid conflicts with other packages.
- Fixed WebGL WebSocket.jspre function name collisions by renaming
initDynCallstoinitDynCalls_websockets - Updated test server URI from
wss://echo.websocket.eventstowss://echo.websocket.org - Updated Unity editor version and package dependencies
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ProjectSettings/ProjectVersion.txt | Updated Unity editor version from 2021.3.45f1 to 2021.3.45f2 |
| Packages/manifest.json | Updated dependency versions for IDE packages and build pipeline |
| Packages/com.utilities.websockets/package.json | Bumped package version from 1.0.6 to 1.0.7 |
| Packages/com.utilities.websockets/Tests/TestFixture_01.cs | Updated test to use new echo server address and introduced constant for server URI |
| Packages/com.utilities.websockets/Samples~/WebsocketDemo/WebSocketDemo.unity | Updated demo scene to use new echo server address |
| Packages/com.utilities.websockets/Runtime/Plugins/WebSocket.jspre | Renamed initDynCalls to initDynCalls_websockets to prevent name collisions |
| .gitignore | Added boot.config to ignored files |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
StephenHodgson
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Utilities.Websockets/Packages/com.utilities.websockets/Runtime/Plugins/WebSocket.jspre
Show resolved
Hide resolved
- fixed webgl WebSocket.jspre function name collisions - update testing server uri - update unit tests - update validation workflows - update unity editor to 2021.3.45f2 (88f88f591b2e)
1 participant
Uh oh!
There was an error while loading. Please reload this page.